define CAMP_USE_PLATFORM_DEFAULT_STREAM, if built with mfem+raja#1893
Closed
chapman39 wants to merge 4 commits into
Closed
define CAMP_USE_PLATFORM_DEFAULT_STREAM, if built with mfem+raja#1893chapman39 wants to merge 4 commits into
CAMP_USE_PLATFORM_DEFAULT_STREAM, if built with mfem+raja#1893chapman39 wants to merge 4 commits into
Conversation
chapman39
added
bug
5 tasks
Member
|
I do not agree with this approach. We should really be pushing back against MFEM: mfem/mfem#5382. If you go down this path you are only making the problem worse. |
Member
|
MFEM is already working on a fix: mfem/mfem#5383 |
Contributor
Author
|
i agree. thank you @adayton1 . closing this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent MFEM PR checks if
CAMP_USE_PLATFORM_DEFAULT_STREAM=1. This is a new restriction essentially forcing camp to use default platform stream, if MFEM is built with RAJA. https://github.com/mfem/mfem/pull/5349/changesHowever if camp or RAJA are included first, then
CAMP_USE_PLATFORM_DEFAULT_STREAMwill be set to0by default. https://github.com/llnl/camp/blob/3e702a10cbf31877e17e83558d2c4abf47960c8b/include/camp/defines.hpp#L164-L168So, the solution is to either mass change the order of include headers such that MFEM is always first, or define the camp macro in the axom config header, so its guaranteed to be defined first.
Another detail is it would be more accurate to also check if
MFEM_USE_RAJA. However, given that would require including MFEM's config header within Axom's, i figured itd be safer to skip the check and always setCAMP_USE_PLATFORM_DEFAULT_STREAMif Axom is built with MFEM.