Reconcile axom spack package.#1891
Merged
BradWhitlock merged 5 commits intoJun 26, 2026
Merged
Conversation
kennyweiss
approved these changes
Jun 24, 2026
Comment on lines
+421
to
+422
| # Remove unusable -Mfreeform flag injected by spack | ||
| entries = [entry.replace("-Mfreeform", "") for entry in entries] |
Member
There was a problem hiding this comment.
👍 Nice! The -Mfreeform flag generates lots of warning
| with when("+profiling"): | ||
| depends_on("adiak") | ||
| depends_on("caliper") | ||
| depends_on("caliper+adiak~papi") |
Member
There was a problem hiding this comment.
I don't think it matters too much since we're deprecating the profiling variant, but it seems weird to unconditionally require that papi is disabled for caliper.
I moved this constraint to defaults.yaml in ebafb95 and it looks like it should be upstreamed to spack-packages (very low priority though)
| variant("umpire", default=True, description="Build with umpire") | ||
|
|
||
| variant("int64", default=True, description="Use 64bit integers for IndexType") | ||
| variant("raja", default=True, description="Build with raja") |
Member
There was a problem hiding this comment.
Minor: Since this list is alphabetized, raja should probably be between opencascade and scr
Member
Author
There was a problem hiding this comment.
I can put it back. I was just trying to minimize code differences with the spack-packages version.
rhornung67
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1890 by incorporating some formatting changes and small bug-fixes from the spack-packages axom package.py into the axom repo package.py.