Task/rhornung67/mv sidre array example#1590
Merged
Merged
Conversation
rhornung67
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
gunney1,
kennyweiss,
publixsubfan and
white238
June 19, 2025 22:28
white238
approved these changes
Jun 20, 2025
BradWhitlock
approved these changes
Jun 23, 2025
BradWhitlock
left a comment
BradWhitlock
left a comment
Member
There was a problem hiding this comment.
Nice improvements to comments.
Arlie-Capps
reviewed
Jun 23, 2025
| std::cout << std::endl; | ||
| // END DEBUG | ||
|
|
||
| // STEP 3a: Create a new sidre::MCArray with data held in a View in the |
Arlie-Capps
approved these changes
Jun 23, 2025
Arlie-Capps
left a comment
Arlie-Capps
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Rich. Much clearer. One possible typo.
kennyweiss
approved these changes
Jun 27, 2025
kennyweiss
left a comment
kennyweiss
left a comment
Member
There was a problem hiding this comment.
Thanks @rhornung67
This example requires MPI. Should we generalize it slightly to also work when MPI is not available? (In that case, we wouldn't be able to use SPIO).
Member
Yes -- just a few comments to show that |
Reviewer comment. Co-authored-by: Kenny Weiss <kennyweiss@users.noreply.github.com>
Member
Author
|
@kennyweiss I added an issue to capture your suggestion: #1598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sidre_array.cpptosidre_mcarray.cppsince it uses sidre::MCArrayResolves #663
@kennyweiss is this what you had in mind for the issue linked above?