[WIP] Add Branson Monte Carlo Kernel#683
Draft
michaelmckinsey1 wants to merge 1 commit into
Draft
Conversation
Member
|
Is there a better name for this kernel? |
Contributor
Author
I am open to suggestions, but it can be renamed easily. |
Member
|
I'm fine with the name. @MrBurmark do you have a specific concern about the name? |
Member
|
The name is just very generic. Is the kernel any specific part of the Monty Carlo algorithm? |
Member
That's a good point. A brief scan of the code at the link @michaelmckinsey1 provided above to the Branson code, perhaps something like MC_EVENT_PHOTON_TRANSPORT, if that's not too long. |
Member
|
@michaelmckinsey1 please add a reference implementation to the kernel header file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An intern (@RanivG) will be implementing https://github.com/lanl/branson/blob/3f538e31a51b144b6621d4665f465d8d44ee85b8/src/event_based_transport.h#L323 as a kernel in RAJAPerf.
This PR is a new kernel.
It does the following (modify list as needed):
Apps_TRANSPORT_3DMCkernelAdd reference implementation to header file (see other kernels for examples).
Rename to
MC_EVENT_PHOTON_TRANSPORT