Skip to content

[draft] HEXHEX opt#682

Draft
michaelmckinsey1 wants to merge 5 commits into
developfrom
hexhex-opt
Draft

[draft] HEXHEX opt#682
michaelmckinsey1 wants to merge 5 commits into
developfrom
hexhex-opt

Conversation

@michaelmckinsey1

@michaelmckinsey1 michaelmckinsey1 commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary

An intern (@stingyemperor) will be attempting to implement a different algorithm in INTSC_HEXHEX-BODY. This looks like a lot of changes, but we just made a copy of the existing kernel such that we can run the two side-by-side for performance testing (I could've just built another binary aswell). The end result, if successful, should just be a modification to INTSC_HEXHEX-BODY.cpp.

  • This PR is an optimization
  • It does the following (modify list as needed):
    • Modifies src/apps/INTSC_HEXHEX_NEW-BODY.cpp

@michaelmckinsey1 michaelmckinsey1 self-assigned this May 20, 2026
@MrBurmark

Copy link
Copy Markdown
Member

Having both for now seems like a good idea. @jmgrandy can decide if we want to merge them or not as he added the kernel and knows what it's trying to represent.

@michaelmckinsey1

Copy link
Copy Markdown
Contributor Author

Having both for now seems like a good idea. @jmgrandy can decide if we want to merge them or not as he added the kernel and knows what it's trying to represent.

Ok that's fine. We'll end up renaming it if we keep it separate.

@MrBurmark

Copy link
Copy Markdown
Member

@stingyemperor Can you add slirp and .codex to the .gitignore?

@MrBurmark

MrBurmark commented Jun 9, 2026

Copy link
Copy Markdown
Member

Also please remove the run outputs and build stuff.

@rhornung67

Copy link
Copy Markdown
Member

Please don't commit build directories, run output, codex files, etc. I suggest that when you execute git add you specify specific files rather than using wildcard.

Comment thread src/apps/.gitignore Outdated
@@ -0,0 +1,5 @@
*
!.gitignore
!INTSC_HEXHEX*

@rhornung67 rhornung67 Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that helpful to include these specific file names here. It's better to be sure that when you run git add you are adding what you intend to add -- avoid using wildcards

Please remove this file

Comment thread src/apps/compile_commands.json Outdated
@@ -0,0 +1 @@
/usr/WS2/gupta22/benchpark/matrix/compile_commands.json No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread src/apps/.codex Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread src/apps/slirp.out Outdated
@@ -0,0 +1,80 @@
sent tapfd=5 for tap0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread src/apps/slurm-238759.out Outdated
@@ -0,0 +1 @@
==> Warning: /usr/WS2/gupta22/benchpark/repos/spack_repo/benchpark/packages/cuda/package.py:8: The `llnl` module will be removed in Spack v1.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread src/apps/slurm-238789.out Outdated
@@ -0,0 +1 @@
==> Warning: /usr/WS2/gupta22/benchpark/repos/spack_repo/benchpark/packages/cuda/package.py:8: The `llnl` module will be removed in Spack v1.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread src/apps/slurm-238793.out Outdated
@@ -0,0 +1 @@
==> Warning: /usr/WS2/gupta22/benchpark/repos/spack_repo/benchpark/packages/cuda/package.py:8: The `llnl` module will be removed in Spack v1.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Comment thread src/apps/slurm-238920.out Outdated
@@ -0,0 +1 @@
==> Warning: /usr/WS2/gupta22/benchpark/repos/spack_repo/benchpark/packages/cuda/package.py:8: The `llnl` module will be removed in Spack v1.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

@@ -0,0 +1 @@
/usr/WS2/gupta22/benchpark/workspace/builds/spack-stage-raja-perf-hexhex-opt-ef7ukeql5cvivsrhozb7xsll64mitykq No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

@@ -0,0 +1 @@
/usr/WS2/gupta22/benchpark/workspace/builds/spack-stage-raja-perf-hexhex-opt-lzhesv42i5jtd4wn6dei2x6jcpzmwdsq No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

@@ -0,0 +1,130 @@
#------------------------------------------------------------------------------

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

Comment thread kernel_256_profile_raw.ncu-rep Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

Comment thread kernel_256_profile-base.cali Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

@@ -0,0 +1,108 @@
#------------------------------------------------------------------------------

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

@stingyemperor

Copy link
Copy Markdown

Sorry, when I made initial commit, 610525e, I forgot that I was tracking all the changed files. I will only track changes for the kernel related files similar to 305652f .

I will make a new commit to fix this.

Please don't commit build directories, run output, codex files, etc. I suggest that when you execute git add you specify specific files rather than using wildcard.

@pearce8 pearce8 self-requested a review June 17, 2026 16:23
@pearce8 pearce8 changed the title [WIP] HEXHEX opt HEXHEX opt Jun 26, 2026
@pearce8 pearce8 changed the title HEXHEX opt [draft] HEXHEX opt Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants