Fix test_error chunk offset detection for HDF5 2.1.0#168
Merged
Conversation
Use H5Dget_chunk_info_by_coord (HDF5 1.12+) to dynamically find the chunk's file offset instead of the hardcoded value 3496. HDF5 2.1.0 changed internal file layout so the chunk no longer lives at that address, causing the raw-byte corruption to miss the ZFP stream and yielding only 652 differing values instead of the expected 1408.
Member
|
Whoops...sorry @brtnfld. I hadn't seen your asked for @jhendersonHDF for review. @jhendersonHDF please go ahead and leave a comment here whether the update was ok. If it wasn't, I can unmerge it. |
Collaborator
|
From my reading it looks like the test is just trying to corrupt a bit of the raw data towards the start of the dataset's data (now the first chunk in this case)? If so, this looks fine to me. |
Member
Yes, thats right...so we can exercise error behavior for that kind of data corruption. Ok, thanks for the quick look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use H5Dget_chunk_info_by_coord to dynamically find the chunk's file offset instead of using a hardcoded value.
Fixes #167