Remove subscription_thread_dispatcher.h from public API - #265
Open
stephen-derosa wants to merge 2 commits into
Open
stephen-derosa wants to merge 2 commits into
stephen-derosa wants to merge 2 commits into
Conversation
stephen-derosa
requested review from
a team and
xianshijing-lk
as code owners
September 17, 2026 20:19
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stephen-derosa
force-pushed
the
sderosa/private-subscription-thread-dispatcher
branch
from
September 17, 2026 20:44
42148f8 to
9206faf
Compare
stephen-derosa
force-pushed
the
sderosa/private-subscription-thread-dispatcher
branch
from
September 17, 2026 20:45
9206faf to
01c0487
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
subscription_thread_dispatcher.h:SubscriptionThreadDispatcherwas never meant to be in the public API.This moves it to the
LIVEKIT_INTERNAL_APIand to thesrc/folder.For this change we will create a minor version bump since it was never intended to be in the public API to begin with.