Repository navigation
Share browser state files between Whirl and BrowserSim - #48
Merged
Merged
Conversation
`-O` now sets every option, so these four flags were an arbitrary subset of the 17 keys. Each is now a usage error that names its `-O` form, such as `-O base=URL`. `--browser` stays: the accepted recording ADR keeps it beside `--engine`, and `whirl doctor --browser` names browsers the same way. Tests, the example script, and the docs use `-O` instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrowserSim and Whirl previously saved different state files. Both now read and write
whirl-stateversion 1 in*.state.json, so a captured state can move between the engines without conversion. A real BrowserSim → Whirl → BrowserSim test verifies cookies, localStorage, sessionStorage, IndexedDB records, binary aliases, and deleted auto-increment key history.Stacked on #47 (
cli-settings). The BrowserSim counterpart is local commitb0b0736(Adopt shared Whirl browser state format).0600. Reject output aliases of input files, including symlinks and hard links.Validation:
mise run checkpasses in Whirl, including six new real CLI browser tests and shared-state validation/file-writing tests.