Repository navigation
Conversation
The Fabro settings schema gains `[run.children] auto_approve`, the workflow half of the platform's child-run auto-approval policy. A child run auto-approved by policy is approved by the platform at its start, not by the engine; the standalone runner mounts `stack.child_workflow` graphs in-process, so it reads and acts on nothing there. Accept the section as platform-only, warning `ignored.workflow_toml.run.children`, alongside `[run.scm]` and the other sections Fabro's platform owns.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fabro's platform is adding a policy where a parent workflow can
auto-approve the child runs its workers start: a server setting plus
[run.children] auto_approvein the parent's workflow.toml. Thefrontend refuses unknown
[run.*]keys, so until the section isaccepted, any bundle carrying the opt-in fails admission with
unsupported.workflow_toml.keyeven though the key is a legitimateplatform setting Fabro's own parser accepts.
The engine has no part in that decision. A child's lifecycle approval is
made by Fabro's server when a worker requests the child's start, and the
standalone runner mounts
stack.child_workflowgraphs in-process ratherthan performing any child-run lifecycle of its own. Accept the section as
platform-only, warning
ignored.workflow_toml.run.childrenbeside theother sections Fabro's platform owns, so the file stays fully diagnosed
and nothing is dropped silently.