Repository navigation
Preserve workflow context during native skill expansion - #118
Merged
Merged
Conversation
swerner
marked this pull request as ready for review
October 13, 2026 20:57
Add `Preamble::prefix` so agent and one-shot prompt nodes share the rule that joins the preamble to the node's prompt. Remove the now-unused `AgentConfig::assemble` and keep `Prompt::assembled` private to the backend. In the tests, add a `skill_runtime` helper that always isolates the Fabro home. Replace the boolean context helper with a shared turn runner and a no-expansion check. Move the ACP test's output settings into its DOT source and use the existing `run` helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Simplify passPushed e028683 with cleanups from a reuse, simplification, efficiency, and altitude review. Behavior is unchanged. Fixed
Skipped
Verification
🤖 Generated with Claude Code |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior-stage text such as
smoke-tested via a /tmp buildor feedback mentioning/commitmust remain workflow data. Native agent turns now send only the authored prompt through Pebble's skill expansion, keeping the fidelity preamble,for_eachitem, and output contract outside it. A leading authored/commitstill works with a nonempty preamble, and a template without{{user_input}}cannot discard surrounding context.Absent prompt segments are omitted instead of emitting empty text blocks, which Anthropic rejects. This applies to preambles, suffixes, and empty authored prompts with nonempty context.
Generated repair turns bypass expansion. User-delivered follow-ups retain leading-command support. ACP keeps its existing single assembled text block, and one-shot prompt behavior is unchanged.
Depends on Pebble commit 679cfd1, currently on
codex/skill-command-boundary. Keep this PR in draft until that dependency reaches Pebble main. The manifest retains the requiredbranch = "main"; Cargo.lock pins the published commit. Related: lithoscomputer/pebble#37.Thanks to @denkhaus for the original report, leading-command rule, and regression cases in fabro-sh/fabro#784.
Validation:
embedding_readinessandfabro_differential::fallback_failover_matches_the_pinned_fabro; both pass with the fix. The compatibility CI job also passed after the initial empty-context correction.cargo nextest run --locked --workspace --all-targets --all-features --no-tests=pass --no-fail-fast: 1,755 passed, one watchdog timing test failed under load, nine skipped. The watchdog test passed in the serial rerun; no watchdog code changed.cargo test --locked --workspace --all-features --doc: passed.cargo clippy --locked -p petri-attractor-steps --all-targets --all-features -- -D warnings: passed.mise run fmt:checkand patch whitespace checks: passed.Fabro follow-up: update
docs/public/agents/skills.mdx, “Slash syntax (user input)” and lifecycle step 3. Commands are recognized only at the beginning of authored input after leading whitespace; later slash tokens are ordinary arguments/text. Replace the “preceded by whitespace” and “only one skill reference” rules. Document that workflow preambles, item data, and output contracts stay outside expansion, even for templates without a placeholder. Petri's Attractor format reference is updated here.