Repository navigation
Fix Linux terminal input loss during resize - #40
Merged
Merged
Conversation
swerner
marked this pull request as ready for review
October 14, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux terminal input can stall after a resize when Enter is already waiting. Crossterm 0.29's default Mio reader returns the first event from a readiness batch and can discard the other edge-triggered notification. The first-run key prompt then waits until the terminal test times out. The internal dependency update run tracked by #39 and the latest nightly both show this failure.
Enable Crossterm's
use-dev-ttypolling backend only on Linux. Add a PTY regression that queues resize and Enter before the reader resumes and requires both events to arrive. macOS keeps its existing backend: applying this feature there changed terminal-mode restoration in the earlier experiment.Add
filedescriptor0.8.3, the polling backend's descriptor wrapper. Itsthiserror/thiserror-impl1.0.69 versions already exist in Fabro's lockfile. Existing package versions and git revisions are unchanged.Fixes #39.
Validation:
mise run checkpassed on macOS: 1,683 tests passed, one skipped; formatting, Clippy, doctests, documentation, library feature checks, workflow audit, and whitespace checks passed.enter=false resize=true.b15f47e, including the new Linux regression and the original first-run test. The current implementation and dependency manifests are unchanged from that tested commit. Whitespace checks passed locally, and PR CI will run again on the latest commit.