x11: Do not unminimize windows with initial IconicState#826
Open
zzhiyi wants to merge 1 commit into
Open
Conversation
This fixes XCOM® 2 (SteamID: 268500) keyboard controls not working on Proton experimental_11.0. Wine expects the WM_STATE property to be changed to Iconic after mapping a window with XWMHints.initial_state set to IconicState. This is picked from Mutter commit 3218626d. Below is the original commit message. ``` This is a revert of commit be5c2ebc, adapted to this day and age. While this worked around issues in wine/proton, it did contravene icccm in the interpretation of initially iconic windows. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2043 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3001> ``` Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes XCOM® 2 (SteamID: 268500) keyboard controls not working on Proton experimental_11.0. Wine expects the WM_STATE property to be changed to Iconic after mapping a window with XWMHints.initial_state set to IconicState.
This is picked from Mutter commit 3218626d. Below is the original commit message.
Signed-off-by: Zhiyi Zhang zzhang@codeweavers.com