Skip to content

[improvement][feat] set the PageSize for ListInstances to be the max of 500, add support to filter linodes on ListInstance via an optional tag passed into the CCM#580

Open
AshleyDumaine wants to merge 2 commits into
mainfrom
list-filter
Open

[improvement][feat] set the PageSize for ListInstances to be the max of 500, add support to filter linodes on ListInstance via an optional tag passed into the CCM#580
AshleyDumaine wants to merge 2 commits into
mainfrom
list-filter

Conversation

@AshleyDumaine

@AshleyDumaine AshleyDumaine commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Changes

Previously we were not configuring the ListInstances calls with a page size or a filter so it was grabbing all the linodes in the the account, 100 of them at a time.

This change:

  • Ups the page size to the max of 500, which should cut the calls significantly for accounts with over 100 Linodes in them.
  • Adds support for a new "linode-tag-filter" to be passed in to restrict the instances returned to be just the ones this instance of the CCM cares about (e.g. matches the cluster name via tag)

@github-actions github-actions Bot added improvement for improvements in existing functionality in the changelog. new-feature for new features in the changelog. labels Jun 29, 2026
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.65%. Comparing base (0037f77) to head (c050f70).

Files with missing lines Patch % Lines
cloud/linode/services/instances.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   73.66%   73.65%   -0.02%     
==========================================
  Files          19       19              
  Lines        3023     3029       +6     
==========================================
+ Hits         2227     2231       +4     
- Misses        537      538       +1     
- Partials      259      260       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog. new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant