[improvement][feat] set the PageSize for ListInstances to be the max of 500, add support to filter linodes on ListInstance via an optional tag passed into the CCM#580
Open
AshleyDumaine wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 73.66% 73.65% -0.02%
==========================================
Files 19 19
Lines 3023 3029 +6
==========================================
+ Hits 2227 2231 +4
- Misses 537 538 +1
- Partials 259 260 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
359d9b6 to
066960e
Compare
…to filter linodes on ListInstance via an optional tag passed into the CCM
066960e to
c050f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines:
Changes
Previously we were not configuring the
ListInstancescalls with a page size or a filter so it was grabbing all the linodes in the the account, 100 of them at a time.This change: