Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make column-default derivation failures checked end to end, with typed reasons and stored/incoming origin. Deployment-provided
ColumnDefaultsSourceimplementations can distinguish malformed metadata, incompatible defaults, lookup outages, and internal failures without depending on an HTTP exception.Propagate the checked failure through services/controllers to a dedicated handler, and preserve client-side Iceberg exception classifications and commit-state-unknown behavior.
Details
throws ColumnDefaultExceptiontoColumnDefaultsSource.defaultsand replace theOperation-only model withReason,Origin, and table/field/type context.This branch contains commit
182f1a9505509186fcbc26b8d38f9b8a086efd85. The checked SPI is not in the current published 0.5.499 tables artifact. Consumers require this change to be merged and released before they can update their published dependency pin; no future version number is assumed here.Testing Done
182f1a95, using Java 17-compatible annotation processors and real dependency artifacts.