Revert entityType discriminator and HTS upper-case predicate fix (#696, #758) - #761
Merged
teamurko merged 1 commit intoSep 22, 2026
Merged
Conversation
…nkedin#696)" and "Use upper-case HTS predicates to match the functional index (linkedin#758)" This reverts commit eca3ca3 (linkedin#696) and commit 2cdbb83 (linkedin#758). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
teamurko
approved these changes
Sep 22, 2026
ruolin59
added a commit
to ruolin59/openhouse
that referenced
this pull request
Sep 22, 2026
…#696, linkedin#758 combined) Combines two previously-separate commits into one so the entityType discriminator feature and its required index-compatible predicate lands atomically: - Add entityType discriminator and table-scoped HTS queries (originally linkedin#696) - Use upper-case HTS predicates to match the functional index (originally linkedin#758, a hotfix for a production incident caused by linkedin#696's lower(...) predicates bypassing idx_user_table_upper_db_table) See the reverted PR (linkedin#761 revert of linkedin#696/linkedin#758) for background on why these two were split apart and are now being reintroduced together. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ruolin59
added a commit
to ruolin59/openhouse
that referenced
this pull request
Sep 22, 2026
…fix (linkedin#696, linkedin#758)" (linkedin#761) This reverts the revert in linkedin#761, restoring linkedin#696 and linkedin#758 combined into a single commit: - Add entityType discriminator and table-scoped HTS queries (originally linkedin#696) - Use upper-case HTS predicates to match the functional index (originally linkedin#758, a hotfix for the production incident caused by linkedin#696's handwritten lower(...) predicates bypassing the idx_user_table_upper_db_table functional index) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts two related commits:
#758 was a hotfix for a production incident (HTS connection saturation) caused by
getUserTablescanning the fulluser_table_rowtable instead of using theidx_user_table_upper_db_tablefunctional index, a regression introduced by #696'shandwritten
lower(...)predicates.This PR reverts both changes back to the pre-#696 state, restoring the original
findByDatabaseIdIgnoreCaseAndTableIdIgnoreCase-based query path (which naturallymatched the functional index) and removing the
entity_typediscriminator column,EntityTypeenum, and related JDBC/API/test surface added by #696.A follow-up PR will reintroduce both changes together, combined into a single
commit, so the entityType feature and its required index-compatible predicate fix
land atomically.
Test plan
./gradlew :services:housetables:test :services:common:testpasses../gradlew spotlessCheckpasses (run with-x CopyGitHooksTask, a pre-existingworktree-incompatibility in the git-hooks Gradle task, unrelated to this change).
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com