Repository navigation
Fix pipeline override cleanup and cached options reuse - #189
Merged
cirquare merged 1 commit intoOct 14, 2026
Merged
Conversation
Restore current-thread transform override cleanup after waiting for completed Flink results, and return cached options views before custom initializer discovery to avoid unnecessary access through retired context classloaders. Add regression coverage while retaining cache-miss synchronization, provider error propagation, and other pipeline-result behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore current-thread PTransformOverrideRegistrar cleanup in both completed FlinkRunnerResult.waitUntilFinish overloads, preserving other result APIs.
Restore the cached PipelineOptions view fast path before custom initializer discovery. This avoids unnecessary ServiceLoader access through a retired context classloader while leaving cache-miss synchronization, initialization, and failure propagation unchanged.
Add regressions for cleanup/tag reuse/thread isolation, cached views with and without a custom initializer, and visible failure when an uncached view requires a closed loader.
Testing Done
--rerun-tasksand--no-build-cache. All 285 tasks executed: 9,143 test executions, 23 built-in skips, zero failures/errors.:runners:core-java:test; all other test workers remained at 2 GB. Repository and CI settings, test assertions, and timeouts are unchanged.git diff --checkpassed. Hosted Flink CI will be checked on this PR.