Skip to content

Add more real bugs to regression tests#47

Draft
ligurio wants to merge 2 commits into
develfrom
ligurio/more-real-bugs
Draft

Add more real bugs to regression tests#47
ligurio wants to merge 2 commits into
develfrom
ligurio/more-real-bugs

Conversation

@ligurio

@ligurio ligurio commented Mar 3, 2026

Copy link
Copy Markdown
Owner

No description provided.

@ligurio ligurio marked this pull request as draft March 3, 2026 12:48
@ligurio ligurio force-pushed the ligurio/more-real-bugs branch 4 times, most recently from 06f0d8e to 3fed588 Compare March 18, 2026 07:36
@ligurio ligurio marked this pull request as ready for review March 18, 2026 10:59
@ligurio ligurio requested review from Buristan and aleksisch March 20, 2026 13:36
return res
end

jit.opt.start("hotloop=1")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove all jit.opt.* from repros? We set it manually in ljopt.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break reproducing in runtime

@aleksisch aleksisch Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should reproduce in runtime with same options we run in ljopt, otherwise such runtime checks can give incorrect results (they should guarantee that optimized trace, when run in ljopt, contains a bug).

Comment thread tests/reproducers/lj_1418_slot.lua Outdated
@ligurio ligurio force-pushed the ligurio/more-real-bugs branch 2 times, most recently from ccf0102 to 93f771f Compare March 27, 2026 07:42
@ligurio ligurio marked this pull request as draft April 15, 2026 07:37
@ligurio ligurio force-pushed the ligurio/more-real-bugs branch from 93f771f to 775f002 Compare April 15, 2026 11:25
@ligurio ligurio force-pushed the ligurio/more-real-bugs branch from 775f002 to 8b16d6c Compare June 4, 2026 07:42
Comment thread tests/buggy_luajit_tests.lua Outdated
@ligurio ligurio force-pushed the ligurio/more-real-bugs branch from 8b16d6c to c11547b Compare June 16, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants