Fix Windows OpenUSD binary filename pattern in CI

[syoyo]

Problem

The Windows CI workflow is failing with no assets match the file pattern error when trying to download OpenUSD binaries from the openusd-bin repository.

Root Cause

The workflow was looking for:

openusd-*-minsizerel-win64.zip

But the actual release artifacts use:

openusd-*-minsizerel-windows-x86_64.zip

Changes

Updated .github/workflows/windows_ci.yml to use the correct filename pattern:

• Download pattern: openusd-*-minsizerel-win64.zip → openusd-*-minsizerel-windows-x86_64.zip
• Extract filter: openusd-*-minsizerel-win64.zip → openusd-*-minsizerel-windows-x86_64.zip

This matches the naming convention used in openusd-bin releases where platform names follow GitHub Actions standard identifiers (windows-x86_64, linux-x86_64, macos-arm64, etc).

Related Workflow Run

Failed run: https://github.com/lighttransport/tinyusdz/actions/runs/20870799509/job/59971881070

Testing

The Linux and macOS CI workflows already use the correct patterns and are working fine. This PR brings Windows CI in line with them.

[claude]

Claude finished @syoyo's task —— View job

---

Code Review Completed ✅

I've thoroughly reviewed the Windows CI workflow changes for the OpenUSD binary filename pattern fix.

Todo List:

• Read and analyze the changed workflow file
• Verify the filename pattern fix aligns with the problem description
• Check for code quality and best practices
• Look for potential bugs or issues
• Consider performance implications
• Review security concerns
• Assess test coverage and verification approach
• Provide comprehensive review feedback

Review Feedback

✅ Code Quality & Best Practices

• Clean, focused fix: The changes are minimal and precisely target the specific issue
• Consistent naming: The new pattern windows-x86_64 aligns perfectly with other platform identifiers used in the repository:
  • Linux: linux-x86_64, linux-arm64
  • macOS: macos-arm64
• Complete fix: Both the download pattern and extract filter were updated consistently

✅ Problem Resolution

• Root cause addressed: The change from win64 to windows-x86_64 correctly matches the actual openusd-bin release artifact naming convention
• Evidence-based: The fix is well-documented with reference to the failed CI run
• Verified consistency: I confirmed that no other workflow files still use the old win64 pattern

✅ Technical Correctness

Location: .github/workflows/windows_ci.yml:43,49

• Download pattern: openusd-*-minsizerel-win64.zip → openusd-*-minsizerel-windows-x86_64.zip
• Extract filter: Both references updated consistently
• PowerShell syntax: Proper escaping and variable handling maintained

✅ Security Considerations

• No security concerns: The change only affects filename patterns, not authentication or permissions
• Same repository source: Still downloading from the trusted lighttransport/openusd-bin repository
• Token usage unchanged: Continues to use the secure github.token for authentication

✅ Performance Considerations

• No performance impact: Filename pattern change has no effect on download speed or efficiency
• Same file size: The actual binary being downloaded remains identical

✅ Test Coverage

• Implicit verification: The CI workflow failure itself serves as the test case
• Integration testing: The workflow includes comprehensive OpenUSD interoperability tests that will verify the fix works
• Cross-platform validation: Other platform workflows (Linux, macOS) already use the correct pattern and pass

🎯 Recommendations

1. Merge with confidence - This is a straightforward, well-executed fix
2. Monitor CI runs - Watch for successful completion after merge to confirm the fix works
3. Consider documentation - If this naming convention isn't documented elsewhere, consider noting it for future reference

Summary

This PR represents an excellent example of a focused bug fix. The changes are minimal, well-reasoned, and align with existing patterns in the codebase. The fix addresses the specific CI failure while maintaining consistency across all platform workflows.

Approval recommended ✅

---

[Copilot]

Pull request overview

This PR fixes a CI workflow failure in the Windows build caused by an incorrect filename pattern when downloading OpenUSD binary releases. The workflow was using an outdated pattern (win64) instead of the current standard GitHub Actions platform identifier (windows-x86_64).

Changes:

• Updated OpenUSD binary download pattern from openusd-*-minsizerel-win64.zip to openusd-*-minsizerel-windows-x86_64.zip
• Updated PowerShell file extraction filter to match the new pattern

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[claude]

Claude finished @syoyo's task —— View job

---

Code Review Completed ✅

I've thoroughly reviewed the Windows CI workflow changes for the OpenUSD binary filename pattern fix.

Todo List:

• Read and analyze the changed workflow files
• Verify the filename pattern fix aligns with the problem description
• Check for code quality and best practices
• Look for potential bugs or issues
• Consider performance implications
• Review security concerns
• Assess test coverage and verification approach
• Provide comprehensive review feedback

Review Feedback

✅ Code Quality & Best Practices

• Clean, focused fix: The changes are minimal and precisely target the specific issue
• Consistent naming: The new pattern windows-x86_64 aligns perfectly with other platform identifiers used in the repository:
  • Linux: linux-x86_64, linux-arm64
  • macOS: macos-arm64
• Complete fix: Both the download pattern and extract filter were updated consistently
• Improved extraction logic: The PowerShell extraction code was also enhanced with better directory handling and environment setup

✅ Problem Resolution

Location: .github/workflows/windows_ci.yml:43,49

• Root cause addressed: The change from win64 to windows-x86_64 correctly matches the actual openusd-bin release artifact naming convention
• Evidence-based: The fix is well-documented with reference to the failed CI run
• Verified consistency: I confirmed that no other workflow files still use the old win64 pattern

✅ Technical Correctness

Download pattern change:

# Before
--pattern 'openusd-*-minsizerel-win64.zip'
# After  
--pattern 'openusd-*-minsizerel-windows-x86_64.zip'

Extract filter change:

# Before
$archive = Get-ChildItem -Filter "openusd-*-minsizerel-win64.zip"
# After
$archive = Get-ChildItem -Filter "openusd-*-minsizerel-windows-x86_64.zip"

Enhanced environment setup: The PowerShell script now properly sets up additional required paths:

• $usdRoot\lib and $usdRoot\tbb\bin added to PATH
• PYTHONPATH and PXR_PLUGINPATH_NAME properly configured
• Consistent extraction to dedicated openusd directory

✅ Security Considerations

• No security concerns: The change only affects filename patterns, not authentication or permissions
• Same repository source: Still downloading from the trusted lighttransport/openusd-bin repository
• Token usage unchanged: Continues to use the secure github.token for authentication

✅ Performance Considerations

• No performance impact: Filename pattern change has no effect on download speed or efficiency
• Same file size: The actual binary being downloaded remains identical
• Improved extraction: The new extraction logic is cleaner and more reliable

✅ Test Coverage

• Implicit verification: The CI workflow failure itself serves as the test case
• Integration testing: The workflow includes comprehensive OpenUSD interoperability tests that will verify the fix works:
  • Cross-tool compatibility tests with tusdcat and usdcat
  • File format conversion verification
  • Both ASCII (.usda) and binary (.usdc) format testing
• Cross-platform validation: Other platform workflows (Linux, macOS) already use the correct pattern and pass

🔧 Additional Improvements in This PR

Beyond the filename fix, I notice this PR also includes beneficial changes to Linux and macOS workflows:

• Simplified extraction logic: More consistent extraction patterns across all platforms
• Better environment setup: More complete PATH and library path configuration
• Removal of conditional setup script: Eliminates dependency on potentially missing setup-usd-env.sh file

🎯 Recommendations

1. Merge with confidence - This is a straightforward, well-executed fix
2. Monitor CI runs - Watch for successful completion after merge to confirm the fix works
3. Consider documentation - If this naming convention isn't documented elsewhere, consider noting it for future reference

Summary

This PR represents an excellent example of a focused bug fix. The changes are minimal, well-reasoned, and align with existing patterns in the codebase. The fix addresses the specific CI failure while maintaining consistency across all platform workflows and even includes some beneficial improvements to the extraction and environment setup logic.

Approval recommended ✅

---

[claude]

Claude finished @syoyo's task —— View job

---

Code Review Completed ✅

I've thoroughly reviewed the Windows CI workflow changes for the OpenUSD binary filename pattern fix.

Todo List:

• Read and analyze the changed workflow files
• Verify the filename pattern fix aligns with the problem description
• Check for code quality and best practices
• Look for potential bugs or issues
• Consider performance implications
• Review security concerns
• Assess test coverage and verification approach
• Provide comprehensive review feedback

Review Feedback

✅ Code Quality & Best Practices

• Clean, focused fix: The changes are minimal and precisely target the specific issue
• Consistent naming: The new pattern windows-x86_64 aligns perfectly with other platform identifiers used in the repository:
  • Linux: linux-x86_64, linux-arm64
  • macOS: macos-arm64
• Complete fix: Both the download pattern and extract filter were updated consistently
• Improved environment setup: Enhanced PowerShell script with better path configuration

✅ Problem Resolution

Location: .github/workflows/windows_ci.yml:43,49

• Root cause addressed: The change from win64 to windows-x86_64 correctly matches the actual openusd-bin release artifact naming convention
• Evidence-based: The fix is well-documented with reference to the failed CI run
• Verified consistency: I confirmed that no other workflow files still use the old win64 pattern

✅ Technical Correctness

Download pattern change:

# Before
--pattern 'openusd-*-minsizerel-win64.zip'
# After  
--pattern 'openusd-*-minsizerel-windows-x86_64.zip'

Extract filter change:

# Before
$archive = Get-ChildItem -Filter "openusd-*-minsizerel-win64.zip"
# After
$archive = Get-ChildItem -Filter "openusd-*-minsizerel-windows-x86_64.zip"

Enhanced environment setup: The PowerShell script properly sets up all required paths:

• $usdRoot\lib and $usdRoot\tbb\bin added to PATH
• PYTHONPATH and PXR_PLUGINPATH_NAME properly configured
• Consistent extraction to dedicated openusd directory

✅ Security Considerations

• No security concerns: The change only affects filename patterns, not authentication or permissions
• Same repository source: Still downloading from the trusted lighttransport/openusd-bin repository
• Token usage unchanged: Continues to use the secure github.token for authentication

✅ Performance Considerations

• No performance impact: Filename pattern change has no effect on download speed or efficiency
• Same file size: The actual binary being downloaded remains identical
• Improved extraction: The new extraction logic is cleaner and more reliable

✅ Test Coverage

• Implicit verification: The CI workflow failure itself serves as the test case
• Integration testing: The workflow includes comprehensive OpenUSD interoperability tests that will verify the fix works:
  • Cross-tool compatibility tests with tusdcat and usdcat
  • File format conversion verification
  • Both ASCII (.usda) and binary (.usdc) format testing
• Cross-platform validation: Other platform workflows (Linux, macOS) already use the correct pattern and pass

🔧 Additional Improvements Observed

Beyond the Windows filename fix, this PR also includes beneficial changes to Linux and macOS workflows:

• Simplified extraction logic: More consistent extraction patterns across all platforms
• Better environment setup: More complete PATH and library path configuration
• Removal of conditional logic: Eliminates dependency on potentially missing setup scripts

🎯 Recommendations

1. Merge with confidence - This is a straightforward, well-executed fix
2. Monitor CI runs - Watch for successful completion after merge to confirm the fix works
3. Consider documentation - If this naming convention isn't documented elsewhere, consider noting it for future reference

Summary

This PR represents an excellent example of a focused bug fix. The changes are minimal, well-reasoned, and align with existing patterns in the codebase. The fix addresses the specific CI failure while maintaining consistency across all platform workflows and even includes some beneficial improvements to the extraction and environment setup logic.

Approval recommended ✅

---