Repository navigation
Conversation
hieblmi
reviewed
Aug 14, 2026
Collaborator
There was a problem hiding this comment.
Taproot Assets compatibility
Please bump github.com/lightninglabs/taproot-assets to v0.8.1. This PR already handles its updated rfqmath.UnitsToMilliSatoshi signature, and the bump keeps Loop compatible with litd versions using tapd v0.8.1.
Since v0.8.1 still uses the legacy btcd packages, Loop needs the temporary btcd-v2 replacement. Go does not propagate replace directives to downstream modules, so LiT needs the same replacement until a btcd-v2-compatible Taproot Assets release is available. Please re-run the LiT compatibility jobs with that setup.
This was referenced Oct 21, 2026
Update LND, Aperture, and Taproot Assets to revisions using the btcd v2 modules, and update lndclient to v0.21.0-3. Migrate Loop chain, transaction, and address types to their corresponding v2 packages. The lndclient release includes the migration from: lightninglabs/lndclient#280 Taproot Assets is temporarily replaced with its btcd v2 revision because the v0.8 release branch has not adopted the new modules. This raises the minimum Go version to 1.26 and changes exported address types.
hieblmi
self-requested a review
October 21, 2026 11:05
Use Go's normal module proxy configuration for all four tidy checks. This avoids concurrent direct VCS fetch failures in CI and removes the redundant selective prefetch. Keep checksum verification and the final working-tree consistency check.
hieblmi
added a commit
to hieblmi/loop
that referenced
this pull request
Oct 22, 2026
Port the coordinated source migration from Loop lightninglabs#1199 while keeping Go 1.27.3 and the existing runtime lnd floor. Pin current lnd master and matching submodules, tapd v0.8.6's v2 compatibility revision, and the SDK fixes for proof selection, signing, and activation APIs. Propagate immutable replacements into LoopRPC and LiT compatibility builds because dependency replacements are not inherited. Co-authored-by: Boris Nagaev <bnagaev@gmail.com>
hieblmi
added a commit
to hieblmi/loop
that referenced
this pull request
Oct 23, 2026
Port the coordinated source migration from Loop lightninglabs#1199 while keeping Go 1.27.3 and the existing runtime lnd floor. Pin current lnd master and matching submodules, tapd v0.8.6's v2 compatibility revision, and the SDK fixes for proof selection, signing, and activation APIs. Propagate immutable replacements into LoopRPC and LiT compatibility builds because dependency replacements are not inherited. Co-authored-by: Boris Nagaev <bnagaev@gmail.com>
hieblmi
added a commit
to hieblmi/loop
that referenced
this pull request
Oct 23, 2026
Port the coordinated source migration from Loop lightninglabs#1199 while keeping Go 1.27.3 and the existing runtime lnd floor. Pin current lnd master and matching submodules, tapd v0.8.6's v2 compatibility revision, and the SDK fixes for proof selection, signing, and activation APIs. Propagate immutable replacements into LoopRPC and LiT compatibility builds because dependency replacements are not inherited. Co-authored-by: Boris Nagaev <bnagaev@gmail.com>
hieblmi
added a commit
to hieblmi/loop
that referenced
this pull request
Oct 26, 2026
Port the coordinated source migration from Loop lightninglabs#1199 while keeping Go 1.27.3 and the existing runtime lnd floor. Pin current lnd master and matching submodules, tapd v0.8.6's v2 compatibility revision, and the SDK fixes for proof selection, signing, and activation APIs. Propagate immutable replacements into LoopRPC and LiT compatibility builds because dependency replacements are not inherited. Co-authored-by: Boris Nagaev <bnagaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Loop to the btcd v2 modules and Go 1.26.8, rebased onto the current master. Exported Bitcoin address, transaction, hash, script, and chain types now use the corresponding v2 packages. Preserve the current swap-fee, withdrawal, and minimum-runtime-lnd behavior while updating the dependency graph.
Use released lndclient v0.21.0-3, the v2-compatible lnd and Aperture revisions, and the matching wallet and chain modules. Keep Taproot Assets on the fixed v0.8.6 code with a v2 compatibility migration rather than switching to main's different API and incomplete v0.8.6 fix set.
Use lnd revision
f2963ce1fd19, which contains the released v0.21.4 forwarding-response recovery and replay fixes, rather than the older v2 snapshot. Align the SQL, queue, and result-helper modules with that revision and build with Go 1.26.8.Module checks honor the configured Go proxy to avoid Git cache fetch races, while retaining all four tidy checks and the failure on a modified working tree.
Companion migrations
Temporary fork replacements pin immutable source revisions. Before release, replace these with accepted upstream revisions or tags. Review and land Taproot Assets, Pool, and Faraday first; then Loop and its RPC modules; then LiT. Tagged shared dependencies and subservers can be adopted at each stage.
Validation
Keep this draft while the coordinated dependency migrations are reviewed and the temporary pins are replaced. The btcd v2 import changes affect Go callers; the runtime lnd minimum remains v0.19.0-beta, based on the actual RPC behavior Loop requires.
Pull Request Checklist
docs/release-notes/release-notes-next.md, or apply theno-changeloglabel.