This repository was archived by the owner on May 20, 2026. It is now read-only.
Conversation
Contributor
Author
|
Hey @thetarnav - I am playing with this in the demo app and have: My question is I'm running the preload in a runWithOwner, but even so the Memo that is returned still gets cleaned up. export function browsePreload(props) {
const params = props().params;
return createMemo(() => {
const provider = browseProvider(params.filter || "all");
provider(1);
onCleanup(() => {
console.log('bye memo')
});
return provider;
});
}The browse page is not being cleaned up... Another question is the params are created in the router and I can't change their owner (or can i?) - Let me know your thoughts on this approach. Browse page is caching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.