feat(build): add Mac App Store (mas) target alongside Developer ID#20
Merged
Conversation
Adds a sandboxed Mac App Store build path without disturbing the existing
DMG / Developer ID distribution.
- electron-builder.json:
- mas: sign the app with the Apple Distribution identity and reference the
embedded provisioning profile (installer cert is auto-detected). App
Sandbox entitlements were already present.
- drop the redundant ffmpeg-static extraResources copy — the app runs the
asarUnpack'd binary (which electron-builder already signs), so this only
removed ~45MB of unused, duplicate executable from every build.
- appId -> io.out-loud.outloud to match App Store Connect / the profile.
- scripts/verify-mas-build.mjs: post-build smoke-test asserting the bundle is
store-ready (Apple Distribution signature, App Sandbox, embedded profile,
every nested Mach-O incl. ffmpeg signed + com.apple.security.inherit,
codesign --verify --deep --strict, not hardened).
- package.json: add verify:mas and chain it onto electron:build:mas.
The custom GitHub-releases update poller is already disabled under MAS via
process.mas, so no auto-update changes were needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a sandboxed Mac App Store build path without disturbing the existing DMG / Developer ID distribution. Both channels build from the same config.
Changes
electron-builder.jsonmas: sign the app with the Apple Distribution identity and reference the embedded provisioning profile (build-resources/embedded.provisionprofile). The installer cert (3rd Party Mac Developer Installer) is auto-detected — electron-builder 26 exposes no field for it. App Sandbox entitlements (entitlements.mas.plist+.inherit.plist) were already in place.ffmpeg-staticextraResourcescopy. The app runs theasarUnpack'd binary (which electron-builder already signs — verifiedTeamIdentifier=8Y2UTZ2NBZ), so this only dropped ~45 MB of unused, duplicate executable from every build.appId→io.out-loud.outloudto match App Store Connect / the provisioning profile.scripts/verify-mas-build.mjs(new)com.apple.security.inherit,codesign --verify --deep --strict, and not hardened.package.jsonverify:mas; chained it ontoelectron:build:masso the build self-verifies before you ever open Transporter.Not changed (already correct)
process.mas— no change needed.appId.Before merging / releasing
build-resources/embedded.provisionprofile.io.out-loud.outloud.npm run electron:build:mas→.pkginreleases/macos/(self-verifies)..pkglocally and confirm mp3 export / speed-change work under the real sandbox, then upload via Transporter.