Skip to content

fix(native): even the Pulls row hover and mirror the screen in its skeleton - #999

Merged
omartelo merged 1 commit into
mainfrom
fix/pulls-hover-and-skeleton
Oct 30, 2026
Merged

omartelo merged 1 commit into
mainfrom
fix/pulls-hover-and-skeleton

Conversation

@omartelo

Copy link
Copy Markdown
Collaborator

Summary

  • Row hover: the tab panels' scroll list (Overview, Conversation, Commits, Checks) reserved the scrollbar's width beside the rows, so a row's hover sat farther from the island's right edge than its left. The bar now overlays the rows (material.Overlay), as the index and the sidebar already do; the hover keeps 8px on both sides.
  • Loading skeleton: the generic stack of bars is replaced by a mirror of the pull request view: title and stats in the header strip, the tab strip and its seam, then the Overview's description beside its facts (stacked on a narrow island), or rows shaped like the Conversation, Commits and Checks rows (glyph, title, subtitle) when another tab is open. withToolbar takes the heading widget instead of the *PRDetail, so the skeleton's heading sits where the title will land.
  • native/DESIGN.md gains both rules: a scrolling list overlays its bar, and a skeleton mirrors its screen.

No CHANGELOG entry: the Pulls redesign is still under [Unreleased].

Test plan

  • gofmt -l ., go vet ./cmd/lich-native, go test ./cmd/lich-native from native/
  • Headless render of the skeleton (Overview and rows) and of the Checks rows: skeleton rows match the real ones (glyph at x=18, text at x=46, 52px per row), Checks hover 8px from both edges

…eleton

The tab panels' scroll list reserved the scrollbar's width beside the rows,
so a row's hover sat farther from the island's right edge than its left.
The bar now overlays the rows, as the index and the sidebar already do.

The loading skeleton was a generic stack of bars. It now mirrors the pull
request it waits for: the title and stats in the header strip, the tab
strip, then the Overview's description beside its facts, or rows shaped
like the other tabs' rows. Both rules land in native/DESIGN.md.
@omartelo
omartelo merged commit a6dfa63 into main Oct 30, 2026
7 checks passed
@omartelo
omartelo deleted the fix/pulls-hover-and-skeleton branch October 30, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant