Repository navigation
fix(native): even the Pulls row hover and mirror the screen in its skeleton - #999
Merged
Merged
Conversation
…eleton The tab panels' scroll list reserved the scrollbar's width beside the rows, so a row's hover sat farther from the island's right edge than its left. The bar now overlays the rows, as the index and the sidebar already do. The loading skeleton was a generic stack of bars. It now mirrors the pull request it waits for: the title and stats in the header strip, the tab strip, then the Overview's description beside its facts, or rows shaped like the other tabs' rows. Both rules land in native/DESIGN.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
material.Overlay), as the index and the sidebar already do; the hover keeps 8px on both sides.withToolbartakes the heading widget instead of the*PRDetail, so the skeleton's heading sits where the title will land.native/DESIGN.mdgains both rules: a scrolling list overlays its bar, and a skeleton mirrors its screen.No CHANGELOG entry: the Pulls redesign is still under
[Unreleased].Test plan
gofmt -l .,go vet ./cmd/lich-native,go test ./cmd/lich-nativefromnative/