Repository navigation
test(browser): draw the page before holding a dialog in the pane test - #965
Merged
Merged
Conversation
TestChromeAPaneOpenedOnADialogShowsThePage failed on every macos-latest run since #958: headless Chrome on macOS has not painted the page when Navigate returns, and a dialog held open before the first paint leaves the screencast no frame to send. The test asserted a frame of a page that was never drawn, which the contract never promised; a dialog opened by an agent's click comes after the page has been drawn. Measured on the runner: with the page drawn first (a screenshot, a prior screencast or two idle seconds) the held page casts within 25 ms; without, no frame in 15 s. The gap for a dialog opened before the first paint is written down in docs/ceilings.md.
omartelo
force-pushed
the
fix/macos-held-dialog-frame
branch
from
October 28, 2026 16:43
3dcbe3b to
9d79dd1
Compare
omartelo
changed the title
omartelo
marked this pull request as ready for review
October 28, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the macos-latest failure of
TestChromeAPaneOpenedOnADialogShowsThePageon main since #958.Headless Chrome on macOS has not painted the page when
Navigatereturns; a dialog held open before that first paint leaves the screencast nothing to send. Measured on the runner (Chrome 155): page drawn first (screenshot, earlier screencast, or 2 s idle) casts within 25 ms; not drawn, no frame in 15 s. The test asserted a frame of a page never drawn, which the contract never promised, so it now draws the page first, as an agent's click would have. The gap for a dialog opened before first paint goes intodocs/ceilings.md.Test plan
go test -count=5 -run 'TestChromeAPaneOpenedOnADialog|TestChromeADialog' ./internal/browser/on Linux