Repository navigation
ci(release): pin task and nfpm instead of installing @latest - #951
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release jobs installed
taskandnfpmwithgo install …@latest, so each release resolved and downloaded whatever the latest tool releases were that day. Pins them to task v3.54.0 and nfpm v2.48.0 across the linux, windows and mac jobs, so every release installs the same tools and a new upstream release cannot change or break packaging on its own.Prompted by the v0.80.0 linux job failing in this step (proxy.golang.org returned an HTTP/2 INTERNAL_ERROR while fetching
golang.org/x/net). Pinning does not stop that kind of proxy hiccup by itself; it removes the drift.GOTOOLCHAIN: autostays on the step: both pinned releases declare go 1.26.4, below our 1.27, but a later bump may ask for more.Test plan
release.ymlonly runs on a tag; the pinned versions resolve on proxy.golang.org (go list -m).