Repository navigation
feat(relay): tell the session that opened one in the merged checkout - #899
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A merge on the Pulls screen already told the live provider sessions in the merged checkout. The session that opened one of them (its
OriginSessionID) handed that work out and keeps notes on it too, but heard nothing, so the user had to tell it by hand.AnnounceMergenow builds its audience inmergeAudience: the live provider sessions in the checkout, then the live provider session that opened each of them, wherever it runs, each told once.deliver, mod or typed, for every provider.docs/ceilings.md.Test plan
TestAnnounceMergeTellsTheSessionThatOpenedOneThere: opener in another project hears it once for two sessions it opened there, a nested opener inside the checkout hears it once, a bystander hears nothing. Fails without the change.go test -count=3 ./internal/relay/,go vet,gofmtclean.