Repository navigation
feat(native): put the Pulls description's Edit in a ⋯ menu and draw task lists and heading rules - #1003
Merged
Conversation
…ask lists and heading rules The Overview's Edit button beside the Description heading becomes a ⋯ menu with Copy link, Copy Markdown and Edit, the way GitHub's comments offer them. Markdown task list items draw a read-only checkbox in the bullet's place, and h1/h2 headings get GitHub's rule underneath, with headings at GitHub's 1.25 line height so the rule sits close to its text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskListextension (already a dependency) is on; a[x]/[ ]item draws the UI kit'sCheckbox, read-only, in the bullet's place, centred on the first line. The marker column widens to the box.th.Separatorunder them, and every heading uses GitHub's 1.25 line height so the rule sits close to its text, with the usual block gap below.CHANGELOG.mdhas the entries.Tests:
TestPullsDescriptionCancelInTheFrameThatTookTheClicknow opens the ⋯ before clicking Edit (the contract changed: Edit moved into the menu); its assertion is unchanged. The Markdown test theme gets a surface (th.On(th.Background)), which the separator and checkbox need to draw, as every real window has.Test plan
[x], and the marker column fits the box; only h1/h2 carry a rule.native/: gofmt, vet and tests green, after rebasing on main.