Repository navigation
fix(native): wrap the Pulls review verdict and widen the Overview facts column - #1000
Merged
Merged
Conversation
…ts column "Changes requested · all threads resolved" was cut off in the 280dp facts column. The column is now 320dp and a stat's text wraps instead of truncating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review verdict "Changes requested · all threads resolved" was cut off in the Overview's facts column on the Pulls screen.
overviewFactsWidthgoes from 280dp to 320dp; the description keeps at least 440dp, since the column only sits beside it from 760dp.statlays its text out withMaxLines = 0, so a verdict that does not fit wraps instead of truncating. The text staysRigid, so it only wraps when it has to, here and in the status line of the other tabs.No CHANGELOG entry: the Overview facts column is still under
[Unreleased].Test plan
go vet ./cmd/lich-nativeandgo test ./cmd/lich-nativefromnative/.