Purge or address pylints#282
Conversation
| @@ -20,11 +20,9 @@ | |||
| from typing_extensions import Self | |||
There was a problem hiding this comment.
I'm not sure about these changes, this is a bit misleading, and looks weird. I think maybe what we want is type(Undefined).
There was a problem hiding this comment.
Ah I see. I was a bit confused as to why UNDEFINED was being used here. So we want this to point to pybind11_builtins.pybind11_type?
There was a problem hiding this comment.
Yes exactly although I'm not sure how to get hold of that "correctly"
There was a problem hiding this comment.
I've updated this following from our discussion yesterday, with a comment about why we have done what we've done. An additional step would be to add runtime checks like isinstance(cxx_type, type(Undefined)) if we really care about type correctness in these functions.
Joseph-Edwards
force-pushed
the
unused-imports
branch
from
8100a21 to
2e7cb70
Compare
2 participants
This PR removes many unnecessary pylint warnings and, where possible, fixes some warnings we were previously disabling.