Use the correct error types#258
Merged
james-d-mitchell merged 9 commits intoJun 9, 2025
Merged
Conversation
Joseph-Edwards
force-pushed
the
check-correct-errors
branch
from
c90929d to
f3e581c
Compare
james-d-mitchell
left a comment
james-d-mitchell
left a comment
Member
There was a problem hiding this comment.
Obviously the CI test should pass, and I think we should stick to the paradigm that all exceptions raised in libsemigroups C++ code are translated to LibsemigroupsErrors, which it's a little unclear to me if that's what you've implemented. I'll add a couple more specific comments about that.
Collaborator
Author
|
Once libsemigroups/libsemigroups#736 is merged, this PR should be good to go from my perspective. |
Collaborator
Author
|
Upon further consideration, this PR seems like a good place to include the "describe the |
Joseph-Edwards
force-pushed
the
check-correct-errors
branch
from
190036e to
46c6de4
Compare
Member
|
Excellent job @Joseph-Edwards, couldn’t have done any better on the description of the structure of the package! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the correct errors are being thrown, and that we document the errors that actually get thrown. It also updates how we register our custom
LibsemigroupsErrorto move away from some deprecated functions.There are a few places where we arguably throw the wrong error (for example, we throw a
LibsemigroupsErrorrather than aValueErrorwhen trying to add a generator to aFroidurePinwith the wrong degree). We could fix this, but this seems like more hassle than it's worth.