Modernise the build system#237
Merged
Joseph-Edwards merged 19 commits intoMay 13, 2025
Merged
Conversation
Collaborator
Author
|
@james-d-mitchell, this feels like a good point to specify authors and maintainers in the |
5 tasks
Member
|
I have some questions, which we can discuss next week, but this looks really good |
b06e932 to
e80a576
Compare
Collaborator
Author
|
This has now been rebased on top of the latest v1 changes. Other than updating the list of authors, which could be deferred to a different PR, I think this is good to go. |
james-d-mitchell
approved these changes
May 12, 2025
james-d-mitchell
left a comment
Member
There was a problem hiding this comment.
Looks good and happy to merge apart from the one (possible?) issue in the make-lint script.
Joseph-Edwards
commented
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernises the build system, and makes the package adhere some Python good practices. Specifically, this PR does the following:
setup.pyintopyproject.tomlas possible (see the Python Packaging Guide and PEP 518).libsemigroups_pybind11into their own module to prevent circular includes.setuptools-scmto use git information to define the version of the module (see setuptools-scm).environment.ymlandrequirements.txtfiles.libsemigroups_pybind11/intosrc/(see src layout vs flat layout).