notification: Use interface availability to check for Windows version…#16021
Merged
Conversation
… suitability Explicit version checks require application manifests on Win10, or an older version will be reported. Check for the toast notification history interface, which is only available on Win10+, and use that to determine if the Windows version is high enough to support notifications.
madebr
approved these changes
Jul 18, 2026
madebr
left a comment
Contributor
There was a problem hiding this comment.
testnotification.exe now shows notifications on my Windows 10 system.
Contributor
|
With transient notifications ( |
Contributor
Author
|
Oof, some incorrect casting was causing memory to be clobbered when incrementing or decrementing the delegate refcount. Fixed. The fun of dealing with COM from C code… |
Cast from the generic implementation, which has space for the refcount.
Contributor
|
I cannot get the app to crash anymore, and I tried hard :) |
Contributor
Author
|
Then let's merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… suitability
Explicit version checks require application manifests on Win10, or an older version will be reported. Check for the toast notification history interface, which is only available on Win10+, and use that to determine if the Windows version is high enough to support notifications.
@madebr, can you check this on your test system?
Fixes #16017
Closes #16019