joystick: Treat d-pads as hat switches at the SDL_Joystick level.#15869
Open
icculus wants to merge 4 commits into
Open
joystick: Treat d-pads as hat switches at the SDL_Joystick level.#15869icculus wants to merge 4 commits into
icculus wants to merge 4 commits into
Conversation
icculus
force-pushed
the
sdl3-joystick-hat-switches
branch
4 times, most recently
from
9392d56 to
18f8f3a
Compare
icculus
force-pushed
the
sdl3-joystick-hat-switches
branch
from
18f8f3a to
afef15c
Compare
icculus
force-pushed
the
sdl3-joystick-hat-switches
branch
from
afef15c to
9c71092
Compare
Reference Issue libsdl-org#14830. [sdl-ci-filter *]
icculus
force-pushed
the
sdl3-joystick-hat-switches
branch
from
9c71092 to
a28c7f2
Compare
Collaborator
Author
|
Okay, this is implemented for all the backends in question now, and it all compiles (full CI is over here). Any testing that can be done would be appreciated; I don't have a setup for any of these platforms (N3DS, PS2, PSP, Vita). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a draft, because there are more platforms to rework yet. This adjusts the n3ds backend, but apparently PS2, PSP, and Vita need similar efforts.(EDIT: all platforms are done.)Also, I do not have any way to even compile this code at the moment, so it could be totally broken. @ccawley2011, if you could give this a try, I'd appreciate it. The Snake demo example should work now, if I didn't screw this up, and examples/input/01-joystick-polling should now have a working dpad showing at the bottom of the display, four less buttons listed at the top, and all of the remaining buttons still pressable.
Fixes #14830.