You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I confirm that I am the author of this code and release it to the SDL project under the Zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").
Adds the 2 missing player LED patterns supported by the PS5 DualSense controller
Description
I'm running an app using SDL where I support 6 controllers. It'd be nice to give visual feedback to our users using the player LEDs which slot they're in. For Switch controllers, this works as the API switches to a semi binary representation for the 4 LEDs above player index 4. The PS5 controllers stopped at a max of 5 for player index, even though the PS5 controller has 7 supported light patterns. This PR adds the 2 extra light patterns (10001 and 01110) as players 6 and 7.
I confirm that I am the author of this code and release it to the SDL project under the Zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").
Adds the 2 missing player LED patterns supported by the PS5 DualSense controller
Description
I'm running an app using SDL where I support 6 controllers. It'd be nice to give visual feedback to our users using the player LEDs which slot they're in. For Switch controllers, this works as the API switches to a semi binary representation for the 4 LEDs above player index 4. The PS5 controllers stopped at a max of 5 for player index, even though the PS5 controller has 7 supported light patterns. This PR adds the 2 extra light patterns (10001 and 01110) as players 6 and 7.
Does it make more sense to use this pattern?
5: 01110
6: 10001
7: 11111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the 2 missing player LED patterns supported by the PS5 DualSense controller
Description
I'm running an app using SDL where I support 6 controllers. It'd be nice to give visual feedback to our users using the player LEDs which slot they're in. For Switch controllers, this works as the API switches to a semi binary representation for the 4 LEDs above player index 4. The PS5 controllers stopped at a max of 5 for player index, even though the PS5 controller has 7 supported light patterns. This PR adds the 2 extra light patterns (10001 and 01110) as players 6 and 7.