vfs: Apply the Virtual File System further#929
Open
RobLoach wants to merge 6 commits into
Open
Conversation
RobLoach
changed the title
Collaborator
|
I'm not sure we really need large files, but it doesn't hurt either I guess. Can you squash the last commit with the 3rd and force-push? |
notaz
reviewed
Jun 26, 2026
| * returns the new file position. We adapt the return value to the | ||
| * fseek semantics (0 on success, -1 on error), so callers that test the | ||
| * result against 0 work under both stdio and VFS. */ | ||
| return core_stdio_fseek_impl((FILE*)file->argp, offset, whence) < 0 ? -1 : 0; |
Collaborator
There was a problem hiding this comment.
You need to send this upstream to https://github.com/rtissera/libchdr and then I'll update the whole libchdr. Otherwise this change will be lost on next libchdr update.
Member
Author
There was a problem hiding this comment.
Good call. Was not quite sure where to push the upstream changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the Virtual File System further, updating to VFS4 to support for larger file sizes with seek_64. The diff is large because of the libretro-common update for VFS4 support.