Skip to content

RequestOptions has all fields private when they should be public #1729

Description

@Diegovsky

As per the title, SpClient::request_with_options allows the user to specify some options. All it differs from SpClient::request is the options param, which takes a &RequestOptions:

pub struct RequestOptions {
    metrics: bool,
    salt: bool,
    base_url: Option<&'static str>,
}

This struct contains useful options and most importantly for me: setting the base_url. I need this to access some special spotify endpoints that use graphQL, such as https://api-partner.spotify.com/pathfinder/v2/query.

Problem is, all the fields are private, which seems like an oversight. Otherwise, all public uses of the struct are just calling Default::default().

If possible, could this be released as 0.8.1? It's a simple fix and we will be needing this endpoint soon at Riff

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions