Skip to content

add ITS standard ETSI TS 102 894-2 - #547

Open
schphil wants to merge 6 commits into
librasn:mainfrom
schphil:ts102894-2
Open

schphil wants to merge 6 commits into
librasn:mainfrom
schphil:ts102894-2

Conversation

@schphil

@schphil schphil commented Mar 15, 2026

Copy link
Copy Markdown

This PR adds the ITS standard ETSI TS 102 894-2.

I was unsure whether it is preferred to include the original ASN.1 sources and generate the Rust code during the build process, or to commit only the generated Rust code. Please let me know if you like this or anything else to be changed.

Comment thread standards/its/src/lib.rs Outdated
@XAMPPRocky

Copy link
Copy Markdown
Collaborator

For the CI failure, you just need to set it to allow for the module, its generated code so you can't fix it. I would also followup with an issue in the compiler repo, it should escape [, ].

Comment thread standards/its/src/lib.rs Outdated
@Nicceboy

Copy link
Copy Markdown
Contributor

For the CI failure, you just need to set it to allow for the module, its generated code so you can't fix it. I would also followup with an issue in the compiler repo, it should escape [, ].

Other ITS modules were partially generated by compiler, but since the output missed so much stuff, they very manually made complete and more usable. Should there be some policy for compiler-only generated code, that it should be only merged if it is fully functional?

@XAMPPRocky

Copy link
Copy Markdown
Collaborator

Should there be some policy for compiler-only generated code, that it should be only merged if it is fully functional?

I mean I would like us to get to the point where the compiler generated code works as expected, and that we are filing bugs against the compiler repo.

I think the only thing I would say around this is keeping the generated code and the handwritten code separate so that the generated code can be regenerated once fixes are merged to the compiler.

@schphil

schphil commented Apr 22, 2026

Copy link
Copy Markdown
Author

@XAMPPRocky do you have any idea why the tests partially failed?

@XAMPPRocky

Copy link
Copy Markdown
Collaborator

It looks like formatting errors and documentation not being in comments to me, why only some failed I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants