Hide period descriptions based on current week#20
Open
humble-ahitofel wants to merge 2 commits into
Open
Conversation
This widget monitors changes in currently displayed week in the library schedule and shows or hides period description based on current week that is viewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following issue was brought by a customer, it seems that if a library has many exceptional weekly schedules with description, then all of those descriptions will be shown underneath the schedule viewer.
I solved this by adding a widget to monitor the schedule viewer and hide/show schedule descriptions based on whether the schedule's time frame is during the current week.
Original issue can be found here: https://projektit.kirjastot.fi/issues/5969