*: Add IfWatcher::poll_if_event instead of IfWatcher::poll_next#25
Merged
Conversation
thomaseizinger
approved these changes
Aug 13, 2022
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Yep, that is what I was thinking!
|
PR title has a typo with |
elenaf9
changed the title
IfWatcher::poll_next take &selfIfWatcher::poll_next take &mut self
Member
|
I am fine with this. Can you add a changelog entry @elenaf9? |
elenaf9
changed the title
IfWatcher::poll_next take &mut selfIfWatcher::poll_if_event instead of IfWatcher::poll_next
3 tasks
mxinden
approved these changes
Aug 19, 2022
Member
Author
|
With this PR merged, all changes from my side required for simplifying the |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
IfWatcherisUnpinwe can makepoll_nexttake&mut selfinstead ofself: Pin<&mut Self>and implementStreamby usingPin::into_inner.Proposed by @thomaseizinger in libp2p/rust-libp2p#2813 (comment).
@thomaseizinger did I understand it correctly that this was the idea?
Also renamed
poll_nexttopoll_if_eventin e56e686 to avoid conflicting names with<IfWatcher as Stream>::poll_next. I don't feel strongly about that, happy to drop that commit it if folks prefer to stick withpoll_next.