Skip OAI list records the requester cannot view (fix WSOD on access-restricted content)#2
Open
daniel-dgi wants to merge 1 commit into
Open
Conversation
ListRecords and ListIdentifiers iterate cached records and call
getHeaderById()/getRecordById() without checking that the entity
loaded. When a cached record references an entity the current
(anonymous) user cannot view -- e.g. published content protected by
node access (Group, embargo, IP restrictions) -- or one that has since
been deleted, loadEntity() sets $this->entity to FALSE and the
subsequent $this->entity->hasField('changed') call throws "Call to a
member function hasField() on false", white-screening the entire
harvest. Only the list verbs are affected; GetRecord already handles a
FALSE entity gracefully (returns idDoesNotExist).
Guard both loops with `if (empty($this->entity)) { continue; }` so
inaccessible or missing records are skipped rather than fataling,
mirroring the FALSE handling getRecord() already performs.
daniel-dgi
force-pushed
the
skip-inaccessible-oai-records
branch
from
ac4bd63 to
1eb425c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We've been having a cache poisoning problem due to how we use groups and accessc ontrol. A full
ListRecords/ListIdentifiersharvest fatals (WSOD) for anonymous harvesters whenever the OAI cache contains a published but access-restricted record (or one that has since been deleted):Rebuilding the cache doesn't seem to change anything. Poisoned entries will get added back into the cache.
So here's a couple null checks. This fixed the problem for us.