2fa webauthn#2785
Open
8by3 wants to merge 4 commits into
Open
Conversation
|
Why does this PR include OTP code? |
Author
The 3 PR's are cumulative as they started as one as splitting them up was a bit messy. The first 1 is clean, second sort of assumes first is ok etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split #2782 into distinct parts, this is Webauth.
@Changaco 🙏
Would need to use a rather old version of webauthn to stick to cbor2 5.3.0
webauthn 1.2.1: cbor2 >=4.0.1
webauthn 1.3.0+: cbor2 >=5.4.2.post1
webauthn 2.3.0+: cbor2 >=5.6.5
Seems prudent to bump cbor2 with this change to get v2 of webauthn now and get a bit of forward movement of cbor2 at the same time.
1 of 3 #2783
2 of 3 #2785
3 of 3 #2784