Introduce License Finder to CI by masutaka · Pull Request #94 · liam-hq/liam

masutaka · 2024-11-22T08:44:21Z

Summary

This PR introduces License Finder to CI for maintaining license compliance.

In the future, CI will fail if you use licenses or packages that are not allowed in frontend/config/dependency_decisions.yml
Whenever there is a change in the packages used by this repository or their licenses, CI will update frontend/docs/packages-license.md

Related Issues and pull requests

Changes

Resolve all license issues from License Finder
Introduce License Finder to CI

Testing

First commit, CI created frontend/docs/packages-license.md
- https://github.com/liam-hq/liam/actions/runs/12079114800/job/33684512623
Triggered by 1. Since neither running License Finder nor creating a license report was necessary, they were skipped
- https://github.com/liam-hq/liam/actions/runs/12079118641/job/33684522889

Other Information

Added Repository variable CI_TRIGGER_APP_ID
Added Repository secret CI_TRIGGER_APP_PRIVATE_KEY
After merging the PRs, set up the license_finder job to require success before the main branch merge

@masutaka

$ license_finder permitted_licenses add 'MIT' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/MIT' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'Apache 2.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/apache-2-0' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'ISC' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/isc-license-txt' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'BSD 0-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/0BSD' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'BSD 2-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/BSD-2-Clause' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'BSD 3-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/BSD-3-Clause' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'BlueOak-1.0.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/blue-oak-model-license' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'The Unlicense' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/Unlicense' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'CC-BY-4.0' \ --why 'Compatible with Apache-2.0 license. See https://creativecommons.org/licenses/by/4.0/' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder approvals add 'argparse' \ --version=2.0.1 \ --why 'Python 2.0 license is compatible with Apache-2.0. But License Finder does not support the name "Python-2.0". See pivotal/LicenseFinder#1053' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder approvals add 'jsonify' \ --version=0.0.1 \ --why 'Public Domain is compatible with Apache-2.0. But it is not a software license. See #111' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder approvals add 'libpg-query' \ --version=13.3.2 \ --why 'Its license is MIT, but it is mis-detected as a "LICENSE IN LICENSE" license. See constructive-io/libpg-query-node#85' \ --who 'OSPO @masutaka'

MH4GF

LGTM 🚀
Thanks a lot of your work!!

MH4GF · 2024-11-29T05:19:28Z

This is pretty straightforward! 😄

MH4GF · 2024-11-29T05:20:37Z

+    :why: Public Domain is compatible with Apache-2.0. But it is not a software license.
+      See https://github.com/liam-hq/liam/issues/111


OK
Thanks 🙏🏻

masutaka · 2024-11-29T08:42:02Z

@MH4GF

Can you add it to the Required Status Check later?

I forgot to set the merge_group trigger, so I added the commit ca5b006 . In the meantime, please review.

MH4GF

LGTM 😄

masutaka · 2024-11-29T08:48:50Z

The main branch had more licenses and I will deal with them.

🔗 https://github.com/liam-hq/liam/actions/runs/12081630218/job/33691096256

@masutaka

$ license_finder permitted_licenses add 'LGPL-3.0-or-later' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/LGPL-3.0' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'CC0 1.0 Universal' \ --why 'Compatible with Apache-2.0 license. See https://creativecommons.org/publicdomain/zero/1.0/' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder approvals add 'spawndamnit' \ --version=3.0.1 \ --why 'Its license is MIT, but it is mis-detected as a "SEE LICENSE IN LICENSE" license. See jamiebuilds/spawndamnit#11' \ --who 'OSPO @masutaka'

@masutaka

$ license_finder permitted_licenses add 'Mozilla Public License 2.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/mpl-2-0' \ --who 'OSPO @masutaka'

It's removed by #110

masutaka · 2024-11-29T09:28:07Z

@MH4GF Please review again.

The main branch had more licenses, so I added commits 2bd8f75...1741ea3 .

9d698a9 and also created a PR jamiebuilds/spawndamnit#11 in connection with it.
Removed libpg-query permissions by 1741ea3 since #110 was merged.

masutaka · 2024-11-29T09:29:21Z

For some reason frontend-ci is down....
https://github.com/liam-hq/liam/actions/runs/12082148738/job/33692660031?pr=94

hoshinotsuyoshi · 2024-11-29T09:33:46Z

For some reason frontend-ci is down....

flaky at main branch 🙏 #108 I'll merge this now. @MH4GF

60e4ed0

MH4GF · 2024-11-29T10:29:55Z

@hoshinotsuyoshi

flaky at main branch 🙏 #108 I'll merge this now.

Thanks 👍🏻
I'll do an update branch and see what happens. @masutaka

MH4GF

LGTM 🚀
License Finder is better to activate it as soon as possible, so I will merge this one.

Create frontend/config/license_finder.yml

155a003

masutaka self-assigned this Nov 22, 2024

masutaka added 9 commits November 22, 2024 17:48

Permit MIT license

5088999

$ license_finder permitted_licenses add 'MIT' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/MIT' \ --who 'OSPO @masutaka'

Permit Apache-2.0 license

f05af99

$ license_finder permitted_licenses add 'Apache 2.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/apache-2-0' \ --who 'OSPO @masutaka'

Permit ISC license

8da3993

$ license_finder permitted_licenses add 'ISC' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/isc-license-txt' \ --who 'OSPO @masutaka'

Permit BSD 0-Clause license

4131ee0

$ license_finder permitted_licenses add 'BSD 0-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/0BSD' \ --who 'OSPO @masutaka'

Permit BSD 2-Clause license

e090967

$ license_finder permitted_licenses add 'BSD 2-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/BSD-2-Clause' \ --who 'OSPO @masutaka'

Permit BSD 3-Clause license

56847a8

$ license_finder permitted_licenses add 'BSD 3-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/BSD-3-Clause' \ --who 'OSPO @masutaka'

Permit Blue Oak Model License

e19bdb1

$ license_finder permitted_licenses add 'BlueOak-1.0.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/blue-oak-model-license' \ --who 'OSPO @masutaka'

Permit The Unlicense

051a3c9

$ license_finder permitted_licenses add 'The Unlicense' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/Unlicense' \ --who 'OSPO @masutaka'

Permit CC BY 4.0 license

52fb94a

$ license_finder permitted_licenses add 'CC-BY-4.0' \ --why 'Compatible with Apache-2.0 license. See https://creativecommons.org/licenses/by/4.0/' \ --who 'OSPO @masutaka'

masutaka force-pushed the introduce-license-finder branch from d1a3f97 to 52fb94a Compare November 28, 2024 08:31

masutaka added 5 commits November 28, 2024 17:55

Approve the argparse v2.0.1 license "Python-2.0"

331b1ed

$ license_finder approvals add 'argparse' \ --version=2.0.1 \ --why 'Python 2.0 license is compatible with Apache-2.0. But License Finder does not support the name "Python-2.0". See pivotal/LicenseFinder#1053' \ --who 'OSPO @masutaka'

Temporary approve jsonify@0.0.1 which is Public Domain

43d6caf

$ license_finder approvals add 'jsonify' \ --version=0.0.1 \ --why 'Public Domain is compatible with Apache-2.0. But it is not a software license. See #111' \ --who 'OSPO @masutaka'

Merge remote-tracking branch 'origin/main' into introduce-license-finder

7abd5c1

Approve libpg-query@13.3.2 which is MIT

bf78899

$ license_finder approvals add 'libpg-query' \ --version=13.3.2 \ --why 'Its license is MIT, but it is mis-detected as a "LICENSE IN LICENSE" license. See constructive-io/libpg-query-node#85' \ --who 'OSPO @masutaka'

Introduce License Finder to CI

f30bf82

masutaka force-pushed the introduce-license-finder branch from f9d4074 to f30bf82 Compare November 29, 2024 04:42

Update docs/packages-license.md

422bd89

masutaka changed the title ~~Introduce License Finder~~ Introduce License Finder to CI Nov 29, 2024

masutaka marked this pull request as ready for review November 29, 2024 05:09

masutaka requested a review from a team as a code owner November 29, 2024 05:09

masutaka requested review from FunamaYukina, MH4GF, hoshinotsuyoshi, junkisai and sasamuku and removed request for a team November 29, 2024 05:09

MH4GF approved these changes Nov 29, 2024

View reviewed changes

masutaka added this pull request to the merge queue Nov 29, 2024

Update docs/packages-license.md

b72ceec

MH4GF approved these changes Nov 29, 2024

View reviewed changes

masutaka added this pull request to the merge queue Nov 29, 2024

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024

masutaka added 6 commits November 29, 2024 18:17

Merge remote-tracking branch 'origin/main' into introduce-license-finder

2bd8f75

Permit LGPL-3.0-or-later license

0b0a09e

$ license_finder permitted_licenses add 'LGPL-3.0-or-later' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/LGPL-3.0' \ --who 'OSPO @masutaka'

Permit CC0 1.0 Universal license

b846e0d

$ license_finder permitted_licenses add 'CC0 1.0 Universal' \ --why 'Compatible with Apache-2.0 license. See https://creativecommons.org/publicdomain/zero/1.0/' \ --who 'OSPO @masutaka'

Approve spawndamnit@3.0.1 which is MIT

9d698a9

$ license_finder approvals add 'spawndamnit' \ --version=3.0.1 \ --why 'Its license is MIT, but it is mis-detected as a "SEE LICENSE IN LICENSE" license. See jamiebuilds/spawndamnit#11' \ --who 'OSPO @masutaka'

Permit Mozilla Public License 2.0

7fbb720

$ license_finder permitted_licenses add 'Mozilla Public License 2.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/mpl-2-0' \ --who 'OSPO @masutaka'

Remove libpg-query from dependency_decisions.yml

1741ea3

It's removed by #110

masutaka force-pushed the introduce-license-finder branch from d4f7cfe to 1741ea3 Compare November 29, 2024 09:21

Update docs/packages-license.md

4042d56

masutaka requested a review from MH4GF November 29, 2024 09:28

hoshinotsuyoshi mentioned this pull request Nov 29, 2024

Primary key icon #108

Merged

1 task

MH4GF and others added 2 commits November 29, 2024 19:29

Merge branch 'main' into introduce-license-finder

9474960

Update docs/packages-license.md

d9a41dd

MH4GF approved these changes Nov 29, 2024

View reviewed changes

MH4GF added this pull request to the merge queue Nov 29, 2024

Merged via the queue into main with commit 2f94337 Nov 29, 2024

MH4GF deleted the introduce-license-finder branch November 29, 2024 10:45

This was referenced Dec 2, 2024

Fix infinity commits by license_finder job #120

Merged

Fix error in the license_finder job in the merge queue #123

Merged

Add license note to README.md #129

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce License Finder to CI#94

Introduce License Finder to CI#94
MH4GF merged 27 commits into
mainfrom
introduce-license-finder

masutaka commented Nov 22, 2024 •

edited

Loading

Uh oh!

MH4GF left a comment

Uh oh!

MH4GF Nov 29, 2024

Uh oh!

MH4GF Nov 29, 2024

Uh oh!

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

MH4GF left a comment

Uh oh!

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

hoshinotsuyoshi commented Nov 29, 2024 •

edited

Loading

Uh oh!

MH4GF commented Nov 29, 2024

Uh oh!

MH4GF left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		:why: Public Domain is compatible with Apache-2.0. But it is not a software license.
		See https://github.com/liam-hq/liam/issues/111

Conversation

masutaka commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issues and pull requests

Changes

Testing

Other Information

Uh oh!

MH4GF left a comment

Choose a reason for hiding this comment

Uh oh!

MH4GF Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

MH4GF Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

MH4GF left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

masutaka commented Nov 29, 2024

Uh oh!

hoshinotsuyoshi commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MH4GF commented Nov 29, 2024

Uh oh!

MH4GF left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

masutaka commented Nov 22, 2024 •

edited

Loading

hoshinotsuyoshi commented Nov 29, 2024 •

edited

Loading

MH4GF left a comment •

edited

Loading