Current sensing#11
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a driver for the ACS3704x-010B3 current sensor and implements core current sensing functionality for the PDU Mk1, including offset collection and reading routines. Feedback highlights a critical naming inconsistency between the source and header files for the offset variable, which will cause linker errors. Other improvements suggested include correcting copy-pasted documentation, averaging multiple samples for more stable calibration, replacing hardcoded channel mapping with descriptive constants, and investigating a "magic delay" in the test code to resolve potential race conditions.
changxu-liu
force-pushed
the
current_sensor_conversion
branch
from
6e67f9f to
ff9b967
Compare
changxu-liu
force-pushed
the
current_sensor_conversion
branch
from
ff9b967 to
cfd2729
Compare
jolynjiang226
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.