Changing RV sign to match the rotation direction#47
Merged
lgrcia merged 2 commits intoDec 17, 2025
Merged
Conversation
Contributor
Author
output_star_phase_minus_theta.mp4output_star_theta_minus_phase.mp4 |
Owner
|
@vatsalpanwar, great and very much needed! Could you change the sign in the RV tests too? (https://github.com/lgrcia/spotter/blob/main/tests/test_rv.py#L34) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current sign of RV calculation returns redshift (positive RV value) for the hemisphere rotating towards the line of sight and vice versa. I have changed this to match the typical convention of the hemisphere rotating towards the line of sight being blueshifted (negative RV values) and vice versa.