Fix (#2412) : Added offline check before pulling a model on server.cpp#2434
Open
GabrielReusRodriguez wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resume
About Issue : #2412
I have added a config check in handle_pull function of server.cpp . Now before checking if user sent a model, we check in config if the model is offline ( offline = "true" ) if it is offline, we send an error response with a user friendly error.
Testing
Tested on ubuntu 24.04 on lemonade 1.8.1 both options with lemonade cli (config.offline= true and config.offline= false).