-
Notifications
You must be signed in to change notification settings - Fork 370
Add MLX backend adapter for lemon-mlx-engine inference #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bong-water-water-bong
wants to merge
4
commits into
lemonade-sdk:main
Choose a base branch
from
bong-water-water-bong:feat/mlx-backend-10.8.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,007
−1,688
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0207176
Fix sd-cpp:metal install by resolving asset filename wildcard (#2402)
jeremyfowers e21fba9
Add MLX backend adapter for lemon-mlx-engine
bong-water-water-bong 5eafe10
Add MLX recipe to Router backend dispatch + fix compilation
bong-water-water-bong 0609837
Fix critical MLX backend bugs from code review
bong-water-water-bong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| #pragma once | ||
|
|
||
| #include "../wrapped_server.h" | ||
| #include "backend_utils.h" | ||
| #include <string> | ||
|
|
||
| namespace lemon { | ||
| namespace backends { | ||
|
|
||
| class MLXServer : public WrappedServer { | ||
| public: | ||
| static InstallParams get_install_params(const std::string& backend, const std::string& version); | ||
|
|
||
| inline static const BackendSpec SPEC = BackendSpec( | ||
| "mlx", | ||
| "mlx-server" | ||
| , get_install_params | ||
| ); | ||
|
|
||
| MLXServer(const std::string& log_level, | ||
| ModelManager* model_manager, | ||
| BackendManager* backend_manager); | ||
|
|
||
| ~MLXServer() override; | ||
|
|
||
| void load(const std::string& model_name, | ||
| const ModelInfo& model_info, | ||
| const RecipeOptions& options, | ||
| bool do_not_upgrade = false) override; | ||
|
|
||
| void unload() override; | ||
|
|
||
| // ICompletionServer implementation | ||
| json chat_completion(const json& request) override; | ||
| json completion(const json& request) override; | ||
| json responses(const json& request) override; | ||
|
|
||
| private: | ||
| std::string model_path_; // Filesystem path for model name rewriting | ||
| }; | ||
|
|
||
| } // namespace backends | ||
| } // namespace lemon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a
systembackend,get_recipe_version()returnsunknownbecause there is no Lemonade-managedversion.txt, but this new expected version makessystem_infomark an otherwise availablemlx-serverasupdate_required. The advertised action islemonade backends install mlx:system, whichBackendManager::install_backend()immediately no-ops forsystem, so users are left with a permanently update-required backend even when the binary is in PATH.Useful? React with 👍 / 👎.