fix: ROCm Support for RDNA2 Device Models#2410
Open
gchriswill wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
engine::llamacpp
superm1
reviewed
Jun 25, 2026
superm1
left a comment
superm1
left a comment
Member
There was a problem hiding this comment.
I think drop the test and then it's fine.
Member
There was a problem hiding this comment.
Honestly I don't see the point of this test. Missing hardware IDs will always happen and the test won't avoid them in future.
Author
There was a problem hiding this comment.
Since there was a modification in the conditional statement logic that checks RDNA2 IDs, and further noticing the absence of test coverage, I thought it might have been good idea to have it. 😅
Author
There was a problem hiding this comment.
But you're right about the IDs and the test. And the only way for the test to catch anything requires the same maintenance (update to constants) as the code itself.
Fixes RX 6000 series detection in system_info.cpp to include 6950, 6900, 6750, and 6650 for gfx103X mapping. Adds test_identify_rocm_arch_from_name.py with comprehensive unit tests replicating the C++ logic, covering all RDNA2 keywords, case handling, vendor guard, and bypass scenarios. Signed-off-by: Christopher Gonzalez <4576678+gchriswill@users.noreply.github.com>
gchriswill
force-pushed
the
rocm-rdna2-devices
branch
from
5dd45d6 to
33fb9f2
Compare
superm1
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes #2403
This pull request fixes support for AMD RDNA2 GPUs (RX 6000 series) in the ROCm architecture detection logic. The fix includes updated device-to-architecture mapping logic in both the code and documentation.
Device detection and mapping improvements:
identify_rocm_arch_from_namefunction insystem_info.cppto explicitly include all relevant RDNA2 model numbers (6950,6900,6800,6750,6700,6650,6600,6500) in the mapping togfx103X, ensuring accurate detection of these GPUs.README.mdto document the addition ofgfx103X(RDNA2) support and list all corresponding Windows-compatible Radeon RX 6000 series GPUs.