Skip to content

feat: alert list 显示规则定义与配置问题#3

Merged
harryisfish merged 1 commit into
mainfrom
feat/alert-list
Jun 9, 2026
Merged

feat: alert list 显示规则定义与配置问题#3
harryisfish merged 1 commit into
mainfrom
feat/alert-list

Conversation

@harryisfish

Copy link
Copy Markdown
Contributor

Summary

  • add smctl alert list for configured alert definitions, including invalid rules ignored by the engine
  • expose read-safe alert definition DTOs through alert status, with webhook query strings and exec arguments redacted
  • document the new command and add regression coverage for invalid-rule visibility and secret redaction

Validation

  • swift test --disable-sandbox (75 tests)
  • git diff --check
  • .build/debug/smctl alert --help
  • .build/debug/smctl alert list --help

Add `smctl alert list` so operators can see configured alert definitions,
including invalid rules that the engine ignores. Surface read-safe action
summaries over the existing status XPC path, redacting webhook query strings
and exec arguments so config tokens do not leak through unauthenticated reads.

Keep alert status backward-compatible with older daemons by making the new
definitions field optional on decode, and add daemon tests for invalid-rule
visibility plus secret redaction.
@harryisfish harryisfish merged commit 9361833 into main Jun 9, 2026
1 check passed
@leaperone-bot leaperone-bot deleted the feat/alert-list branch June 9, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants