feat(daemon): add optional Sentry reporting#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[sentry]daemon config and start Sentry only when a DSN is configured orSMCTL_SENTRY_DSNis provided[sentry]across config rewrites and update privacy docs/man pagePrivacy / operations
sendDefaultPii = false,traces_sample_rate = 0by default, andbeforeSendclears user/server-name fieldsSMCTL_SENTRY_DISABLED=1hard-disables startup for tests or launchd overridesValidation
leaperone/smctlvia localsentry-cli/APIcodex-smokeevent and verified it through the Sentry APIswift test --disable-sandboxswift build -c release --disable-sandboxgit diff --checksmctldhas no@rpath/Sentry.frameworkruntime dependency