Conversation
Collaborator
Author
|
(Adapting mathlib may take a while, reverted this on |
mathlib-bors Bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 27, 2026
…7286) This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
Vtec234
added a commit
that referenced
this pull request
Mar 30, 2026
* chore: move JS build dir to widget/js/ * doc: new pre-built strategy * chore: update widget/js * ci: adjust to changes * chore: bump @leanprover-community/proofwidgets4
mathlib-bors Bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 30, 2026
This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
Rob23oba
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 31, 2026
…er-community#37290) This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
aditya-ramabadran
pushed a commit
to aditya-ramabadran/mathlib4
that referenced
this pull request
Apr 1, 2026
…er-community#37290) This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stores pre-built JavaScript code directly in the source tree instead of asking consumers to fetch it via a combination of Lake cloud releases and (in mathlib) mathlib4/Cache.
Fetching and reuse of this code has unfortunately proved to be unreliable, causing much anguish and gnashing of teeth. This change is not foolproof, in particular caching/reuse issues can still cause the build to fail, but should hopefully reduce the number of components involved.