Extract roadsign-regulation-plugin from plugins repo#1383
Draft
piemonkey wants to merge 12 commits into
Draft
Conversation
Includes making Option code non-private, so we can avoid duplicating this in the plugins repo.
Prevents vite getting errors from incorrect module config
Prevents vite getting errors from incorrect module config
Pull in the two helper functions that we were actually using.
Putting these temporarily in the editor repo allows for us to move out just the roadsign regulation plugin without having to move many dependencies at once and avoids dependency issues from depending on the plugins in the extracted module.
Use monorepo set-up to include the separate module in a way that should avoid maintenance overhead of many repositories. For now the build config is taken and adapted from the editor module.
piemonkey
force-pushed
the
feat/add-ar-import
branch
from
a8f9b4f to
898daab
Compare
It seems weird that this is necessary :s
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This doesn't actually get to the AR-design plugin yet, but the roadsign-regulation plugin should be working in the test app. This is a draft as it hasn't been tested in GN or another consuming app. We'll also need to set up the build scripts for allowing releases and dev releases.
connected issues and PRs:
Part of https://binnenland.atlassian.net/browse/GN-6154
Setup
Shouldn't be necessary.
How to test/reproduce
The test-app has a new page which includes the plugin.
Challenges/uncertainties
So many weird type problems and import changes.
Checks PR readiness